Skip to content

cache/lru: add regression test for cache.Size #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cache/lru: add regression test for cache.Size #331

wants to merge 1 commit into from

Conversation

@starius
Copy link
Contributor

@starius starius commented Nov 7, 2025

Added a regression test for #330

@starius starius requested a review from ffranr November 7, 2025 18:25
@gemini-code-assist
Copy link

gemini-code-assist bot commented Nov 7, 2025

Summary of Changes

Hello @starius, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical regression test for the LRU cache implementation. The new test, TestCacheSizeTracksMutations, ensures the cache.Size() method correctly maintains an accurate count of the total size of elements stored within the cache. This is vital for proper resource management and directly addresses a previous issue, enhancing the reliability of the cache's size accounting under dynamic conditions.

Highlights

  • New Regression Test: A new regression test, TestCacheSizeTracksMutations, has been added to the LRU cache package.
  • Cache Size Tracking: This test specifically verifies that the cache.Size() method accurately reflects the total byte size of elements within the cache across various operations, including insertions, evictions, replacements, and deletions.
  • Addressing Prior Issue: The test serves as a regression for a previously identified issue related to cache size accounting, ensuring the fix remains robust.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 7, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a valuable regression test for the cache.Size functionality, ensuring it correctly reflects the cache's state after various mutations like insertions, evictions, replacements, and deletions. The test cases are well-structured and cover the essential scenarios. I've added a couple of suggestions to make the test assertions more granular, which will help in pinpointing potential issues more precisely in the future.

@starius starius mentioned this pull request Nov 7, 2025
Merged
ffranr
ffranr approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition 👍

@ffranr ffranr force-pushed the wip/add-lru-cache-size-method branch from 3135a7d to 725ab58 Compare November 10, 2025 11:25
@starius starius changed the base branch from wip/add-lru-cache-size-method to master November 10, 2025 19:16
@starius starius requested a review from Roasbeef November 10, 2025 19:17
@starius
Copy link
Contributor Author

starius commented Nov 10, 2025

Rebased this PR since #330 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ffranr ffranr ffranr approved these changes

@Roasbeef Roasbeef Awaiting requested review from Roasbeef

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@starius @ffranr